[webkit-changes] [WebKit/WebKit] f5955e: [ Sonoma+ ] TestWebKitAPI.IndexedDB.IndexedDBFileH...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f5955e181acaa5aacc1c6c573a92697d661d6926
      https://github.com/WebKit/WebKit/commit/f5955e181acaa5aacc1c6c573a92697d661d6926
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm

  Log Message:
  -----------
  [ Sonoma+ ] TestWebKitAPI.IndexedDB.IndexedDBFileHashCollision is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=280704
rdar://137076757

Reviewed by Chris Dumez.

Make a few changes to the test ot make it more robust and consistent:
1. Avoid creating default WKWebsiteDataStore for getting default IndexedDB path, by getting it from default
WKWebsiteDataStoreConfiguration instead. createDirectories() function will delete the path for clearing data, and we
don't want to have an active WebsiteDataStore that may access the path at the time of deletion.
2. Create a custom WKWebsiteDataStore for running the test, and setting unifiedOriginStorageLevel to
_WKUnifiedOriginStorageLevelNone. The current default level is _WKUnifiedOriginStorageLevelStandard, and the test was
added when the level is None.
3. Assert the file operations complete without error. In the test failure case, there is an error log about IndexedDB
directory cannot be created, but it's unclear which operation leads to that error. Adding assertion will help locate the
cause.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm:
(createDirectories):
(TEST(IndexedDB, IndexedDBFileHashCollision)):

Canonical link: https://commits.webkit.org/284902@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications