[webkit-changes] [WebKit/WebKit] 96d957: [Static Analyzer CI] Improve the content and reada...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 96d957f16d1d0481aee6156b2840eb282b65bdd1
      https://github.com/WebKit/WebKit/commit/96d957f16d1d0481aee6156b2840eb282b65bdd1
  Author: Brianna Fan <bfan2 at apple.com>
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
    M Tools/CISupport/ews-build/steps.py
    M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  -----------
  [Static Analyzer CI] Improve the content and readability of the unexpected failures/passes comment
https://bugs.webkit.org/show_bug.cgi?id=281093
rdar://137541288

Reviewed by Ryan Haddad.

Includes information for fixes and failures in one comment when both occur.
Adds code and header formatting to improve readability.
Also fixes a bug where LeaveComment is run twice upon failure.

* Tools/CISupport/ews-build/steps.py:
(DisplaySaferCPPResults):
(DisplaySaferCPPResults.run):
    Improve code clarity and call createComment.
(DisplaySaferCPPResults.getFilesPerProject):
    Remove extra space.
(DisplaySaferCPPResults.createComment): Created.
    Now comments will contain both fixes/failure info when relevant.
    Separate out comment creation for clarity.
    Add LeaveComment and SetBuildSummary to prevent duplication bug.
(DisplaySaferCPPResults.change_type): Created.
    Support both PRs and patches.
(DisplaySaferCPPResults.getResultSummary): Remove comment logic.
* Tools/CISupport/ews-build/steps_unittest.py: Update unit test coverage.

Canonical link: https://commits.webkit.org/284900@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications