[webkit-changes] [WebKit/WebKit] 124bcc: MediaPlayerPrivateRemote should handle its player ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 124bcca6dc13f8981fb65c67259140782e4f4d35
      https://github.com/WebKit/WebKit/commit/124bcca6dc13f8981fb65c67259140782e4f4d35
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
    M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp
    M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h
    M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in
    M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h
    M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.serialization.in
    M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
    M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h
    M Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp

  Log Message:
  -----------
  MediaPlayerPrivateRemote should handle its player client audioOutputDeviceId
https://bugs.webkit.org/show_bug.cgi?id=281052
rdar://problem/137508610

Reviewed by Jer Noble and Jean-Yves Avenard.

To allow setting per media element speaker, we need RemoteMediaPlayerManager to forward to RemoteMediaPlayerProxy the information provided by HTMLMediaElement.
And we need RemoteMediaPlayerProxy to expose that information to its MediaPlayer.
We add this forwarding as IPC message and change in RemoteMediaPlayerProxyConfiguration.

Manually tested.

* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::audioOutputDeviceChanged):
* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h:
* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h:
* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.serialization.in:
* Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::audioOutputDeviceChanged):
* Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
* Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
(WebKit::RemoteMediaPlayerManager::createRemoteMediaPlayer):

Canonical link: https://commits.webkit.org/284880@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications