[webkit-changes] [WebKit/WebKit] 021757: Add support for documentId to message sender object.

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0217575ddd41b0302e6c68c09da31d0f38a7923f
      https://github.com/WebKit/WebKit/commit/0217575ddd41b0302e6c68c09da31d0f38a7923f
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-10-08 (Tue, 08 Oct 2024)

  Changed paths:
    M Source/WebKit/Shared/Extensions/WebExtensionMessageSenderParameters.h
    M Source/WebKit/Shared/Extensions/WebExtensionMessageSenderParameters.serialization.in
    M Source/WebKit/Shared/Extensions/WebExtensionUtilities.h
    M Source/WebKit/Shared/Extensions/WebExtensionUtilities.mm
    M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIRuntimeCocoa.mm
    M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPITabsCocoa.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIRuntime.mm

  Log Message:
  -----------
  Add support for documentId to message sender object.
https://webkit.org/b/281083
rdar://problem/137532821

Reviewed by Brian Weinstein.

Adds support for `documentId` to the `sender` object for `onMessage`, `onConnect`, `onMessageExternal`
and `onConnectExternal` event listeners. `WebCore::Document` already had a `UUID` identifier we can use.

* Source/WebKit/Shared/Extensions/WebExtensionMessageSenderParameters.h:
* Source/WebKit/Shared/Extensions/WebExtensionMessageSenderParameters.serialization.in:
* Source/WebKit/Shared/Extensions/WebExtensionUtilities.h:
* Source/WebKit/Shared/Extensions/WebExtensionUtilities.mm:
(WebKit::toDocumentIdentifier): Added.
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIRuntimeCocoa.mm:
(WebKit::WebExtensionAPIRuntime::sendMessage): Get document identifier or throw error.
(WebKit::WebExtensionAPIRuntime::connect): Ditto.
(WebKit::WebExtensionAPIWebPageRuntime::sendMessage): Ditto.
(WebKit::WebExtensionAPIWebPageRuntime::connect): Ditto.
(WebKit::toWebAPI): Added `documentId` to the result.
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPITabsCocoa.mm:
(WebKit::WebExtensionAPITabs::sendMessage): Get document identifier or throw error.
(WebKit::WebExtensionAPITabs::connect): Ditto.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIRuntime.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIRuntime, SendMessageFromContentScript)): Test `documentId` and use optional chaining.
(TestWebKitAPI::TEST(WKWebExtensionAPIRuntime, SendMessageFromContentScriptWithAsyncReply)): Ditto.
(TestWebKitAPI::TEST(WKWebExtensionAPIRuntime, SendMessageFromContentScriptWithPromiseReply)): Ditto.
(TestWebKitAPI::TEST(WKWebExtensionAPIRuntime, SendMessageFromContentScriptWithAsyncPromiseReply)): Ditto.
(TestWebKitAPI::TEST(WKWebExtensionAPIRuntime, SendMessageFromContentScriptWithNoReply)): Ditto.
(TestWebKitAPI::TEST(WKWebExtensionAPIRuntime, SendMessageFromWebPage)): Ditto.

Canonical link: https://commits.webkit.org/284855@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications