[webkit-changes] [WebKit/WebKit] 18aeb0: AX: Move accessibilityThreadTextApisEnabled to Dep...

[Joshua Hoffman]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 18aeb0e661445201b72923ce20216bc52033b2a3
      https://github.com/WebKit/WebKit/commit/18aeb0e661445201b72923ce20216bc52033b2a3
  Author: Joshua Hoffman <jhoffman23 at apple.com>
  Date:   2024-10-08 (Tue, 08 Oct 2024)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/accessibility/AXCoreObject.cpp
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/page/DeprecatedGlobalSettings.h

  Log Message:
  -----------
  AX: Move accessibilityThreadTextApisEnabled to DeprecatedGlobalSettings
https://bugs.webkit.org/show_bug.cgi?id=281031
rdar://137469268

Reviewed by Tyler Wilcock.

`accessibilityThreadTextApis` tracks global state. Currently, we store this in the Document's
settings, but we can't guarantee the value is the same across different documents. Instead,
let's move it to `DeprecatedGlobalSettings`, and store/access it on the secondary thread using
the existing `gAccessibiltiyThreadTextApisEnabled` atomic bool.

This patch also includes a drive-by build fix for the new `nextUnignoredSiblingOrParent` when
`ENABLE_AX_THREAD_TEXT_APIS` is enabled. These calls were missing the `shouldUpdateChildren`
parameter, which should be true to match the previous behavior.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::nextUnignoredSiblingOrParent const):
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::AXObjectCache):
* Source/WebCore/page/DeprecatedGlobalSettings.h:
(WebCore::DeprecatedGlobalSettings::setAccessibilityThreadTextApisEnabled):
(WebCore::DeprecatedGlobalSettings::accessibilityThreadTextApisEnabled):

Canonical link: https://commits.webkit.org/284827@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications