[webkit-changes] [WebKit/WebKit] ff6a09: [scroll-animations] add support for normalizing th...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ff6a099cb650f08d516a3311a3901ea8a62a3db4
      https://github.com/WebKit/WebKit/commit/ff6a099cb650f08d516a3311a3901ea8a62a3db4
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-10-08 (Tue, 08 Oct 2024)

  Changed paths:
    M Source/WebCore/animation/AnimationEffect.cpp
    M Source/WebCore/animation/AnimationEffect.h
    M Source/WebCore/animation/CSSNumberishTime.cpp
    M Source/WebCore/animation/CSSNumberishTime.h
    M Source/WebCore/animation/KeyframeEffect.cpp
    M Source/WebCore/animation/KeyframeEffect.h

  Log Message:
  -----------
  [scroll-animations] add support for normalizing the specified timing for an animation effect
https://bugs.webkit.org/show_bug.cgi?id=280962
rdar://137412959

Reviewed by Anne van Kesteren.

The Web Animations Level 2 specification introduces the concept of normalizing the specified
timing (https://drafts.csswg.org/web-animations-2/#normalize-specified-timing) such that the
"auto" value can be computed based on the timeline type.

We also noticed that `animationTimelineDidChange()` did not take a `const` pointer as its
argument, although there is no reason for it not to be `const`, so we make that change.

* Source/WebCore/animation/AnimationEffect.cpp:
(WebCore::AnimationEffect::updateTiming):
(WebCore::AnimationEffect::normalizeSpecifiedTiming):
(WebCore::AnimationEffect::animationTimelineDidChange):
* Source/WebCore/animation/AnimationEffect.h:
(WebCore::AnimationEffect::animationTimelineDidChange): Deleted.
* Source/WebCore/animation/CSSNumberishTime.cpp:
(WebCore::CSSNumberishTime::fromMilliseconds):
* Source/WebCore/animation/CSSNumberishTime.h:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::animationTimelineDidChange):
* Source/WebCore/animation/KeyframeEffect.h:

Canonical link: https://commits.webkit.org/284825@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications