[webkit-changes] [WebKit/WebKit] e4dbf9: REGRESSION(284791 at main): wtf/RefTrackerMixin.h(112...

Fujii Hironori noreply at github.com
Mon Oct 7 21:07:36 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e4dbf952205ee07df27025f263bd35db06c9149c
      https://github.com/WebKit/WebKit/commit/e4dbf952205ee07df27025f263bd35db06c9149c
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
    M Source/WTF/wtf/RefTrackerMixin.h

  Log Message:
  -----------
  REGRESSION(284791 at main): wtf/RefTrackerMixin.h(112,36): warning: 'WTF::RefTrackerLoggingDisabledScope::RefTrackerLoggingDisabledScope<T>' redeclared without 'dllimport' attribute: 'dllexport' attribute added
https://bugs.webkit.org/show_bug.cgi?id=281032

Unreviewed build fix for Windows Debug builds.
After <https://commits.webkit.org/284791@main>, it reported an compiler warning.

> wtf/RefTrackerMixin.h(112,36): warning: 'WTF::RefTrackerLoggingDisabledScope::RefTrackerLoggingDisabledScope<T>' redeclared without 'dllimport' attribute: 'dllexport' attribute added [-Winconsistent-dllimport]

WTF_EXPORT_PRIVATE doesn't have to be applied to inline functions.

* Source/WTF/wtf/RefTrackerMixin.h:
(WTF::RefTrackerLoggingDisabledScope::RefTrackerLoggingDisabledScope):
(WTF::RefTrackerLoggingDisabledScope::~RefTrackerLoggingDisabledScope):
(WTF::RefTrackerLoggingDisabledScope<T>::RefTrackerLoggingDisabledScope): Deleted.
(WTF::RefTrackerLoggingDisabledScope<T>::~RefTrackerLoggingDisabledScope): Deleted.

Canonical link: https://commits.webkit.org/284811@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list