[webkit-changes] [WebKit/WebKit] ca00a6: [WebRTC] Crash in webrtc::field_trial::FindFullNam...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ca00a6a0f5f924657977487bd5198ddd3d833c0b
      https://github.com/WebKit/WebKit/commit/ca00a6a0f5f924657977487bd5198ddd3d833c0b
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
    M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp

  Log Message:
  -----------
  [WebRTC] Crash in webrtc::field_trial::FindFullName() calling strlen() on freed C-string
<https://bugs.webkit.org/show_bug.cgi?id=281021>
<rdar://137463467>

Reviewed by Chris Dumez.

* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::LibWebRTCMediaEndpoint):
- webrtc::field_trial::InitFieldTrialsFromString() keeps a reference to
  the C-string passed in, but it does not make its own copy of it, so
  either a global string or a "leaked" copy must be passed in.  This
  changes the LibWebRTCMediaEndpoint() constructor to create two global
  strings and to use whichever one is needed.

Canonical link: https://commits.webkit.org/284806@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications