[webkit-changes] [WebKit/WebKit] 39c575: Discard scrolling to the saved scroll points if th...

Ahmad Saleem noreply at github.com
Mon Oct 7 17:37:55 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 39c5756b4d9c1e4f7fa26c52046af6a0e6c32416
      https://github.com/WebKit/WebKit/commit/39c5756b4d9c1e4f7fa26c52046af6a0e6c32416
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
    A LayoutTests/editing/input/resources/empty-document-goes-back.html
    A LayoutTests/editing/input/reveal-selection-having-stored-scroll-position-expected.txt
    A LayoutTests/editing/input/reveal-selection-having-stored-scroll-position.html
    M Source/WebCore/editing/FrameSelection.cpp

  Log Message:
  -----------
  Discard scrolling to the saved scroll points if there is any selection done by user

https://bugs.webkit.org/show_bug.cgi?id=280116
rdar://problem/136417261

Reviewed by Ryosuke Niwa.

Merge: https://chromium.googlesource.com/chromium/blink/+/f0d674248b2737ea20fb62ab38e71f856a98445f

This patch discards scrolling to saved points on back navigation when the
user has selection done to avoid flicker / jumpiness on back navigation.

* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::FrameSelection::revealSelection):
* LayoutTests/editing/input/reveal-selection-having-stored-scroll-position.html:
* LayoutTests/editing/input/reveal-selection-having-stored-scroll-position-expected.txt:
* LayoutTests/editing/input/resources/empty-document-goes-back.html:

Canonical link: https://commits.webkit.org/284795@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list