[webkit-changes] [WebKit/WebKit] 817035: Remove unneeded [controller awakeFromNib] in MiniB...

Alex Christensen noreply at github.com
Mon Oct 7 15:28:01 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 817035f3a2b688c6562e62672963e416977a020b
      https://github.com/WebKit/WebKit/commit/817035f3a2b688c6562e62672963e416977a020b
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
    M Tools/MiniBrowser/mac/WK2BrowserWindowController.m

  Log Message:
  -----------
  Remove unneeded [controller awakeFromNib] in MiniBrowser's createWebViewWithConfiguration implementation
https://bugs.webkit.org/show_bug.cgi?id=272409
rdar://126150503

Reviewed by Charlie Wolfe.

With that call to awakeFromNib, 2 WKWebViews are created and one is immediately destroyed, which is confusing to debug.
Removing the call does not appear to change any visible behavior in MiniBrowser when window.open is called.

* Tools/MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):

Canonical link: https://commits.webkit.org/284788@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list