[webkit-changes] [WebKit/WebKit] 47d58d: Don't use page tiles for site-isolated root frames.

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 47d58db3a2312ee61e0f5341596b2e4b792d283e
      https://github.com/WebKit/WebKit/commit/47d58db3a2312ee61e0f5341596b2e4b792d283e
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
    A LayoutTests/http/tests/site-isolation/compositing/iframes/resize-from-zero-size-expected.txt
    A LayoutTests/http/tests/site-isolation/compositing/iframes/resize-from-zero-size.html
    M Source/WebCore/rendering/RenderLayerBacking.cpp
    M Source/WebCore/rendering/RenderLayerCompositor.cpp
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm

  Log Message:
  -----------
  Don't use page tiles for site-isolated root frames.
https://bugs.webkit.org/show_bug.cgi?id=280874
<rdar://137259998>

Reviewed by Alex Christensen.

<iframe>s don't create an implicit set of page tiles, they only get tiling
sub-layers as needed based on size.

Currently with site-isolation, and cross-origin <iframe> (a 'root' frame) is
getting page tiles, which will use more memory than is necessary.

The test for this is a duplicate of an existing test (with an identical path,
modulo the http/tests/site-isolation prefix), only changed to access the frame
content via a different origin. The expectation file is also an identical copy.
In the future, we will ideally be able to have both versions of the test
reference the same expectation file, to stop these diverging.

* LayoutTests/http/tests/site-isolation/compositing/iframes/resize-from-zero-size.html: Added.
* LayoutTests/http/tests/site-isolation/compositing/iframes/resize-from-zero-size-expected: Added.
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintsIntoWindow const):
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::shouldUseTiledBackingForFrameView const):

Canonical link: https://commits.webkit.org/284782@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications