[webkit-changes] [WebKit/WebKit] 280763: [scroll-animations] adopt CSSNumberishTime to enqu...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2807638806c1cea5450232c4db6aa17e29232478
      https://github.com/WebKit/WebKit/commit/2807638806c1cea5450232c4db6aa17e29232478
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
    M Source/WebCore/animation/AnimationPlaybackEvent.cpp
    M Source/WebCore/animation/AnimationPlaybackEvent.h
    M Source/WebCore/animation/WebAnimation.cpp
    M Source/WebCore/animation/WebAnimation.h

  Log Message:
  -----------
  [scroll-animations] adopt CSSNumberishTime to enqueue animation events
https://bugs.webkit.org/show_bug.cgi?id=280982
rdar://137432662

Reviewed by Tim Nguyen.

The `WebAnimation::enqueueAnimationPlaybackEvent()` method expected `Seconds` values
which means we can't enqueue progress-based times expressed as percentages for
Scroll-driven Animations. We now switch those to `CSSNumberishTime` which can
encapsulate both seconds and percentages.

* Source/WebCore/animation/AnimationPlaybackEvent.cpp:
(WebCore::AnimationPlaybackEvent::AnimationPlaybackEvent):
* Source/WebCore/animation/AnimationPlaybackEvent.h:
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::cancel):
(WebCore::WebAnimation::enqueueAnimationPlaybackEvent):
(WebCore::WebAnimation::finishNotificationSteps):
* Source/WebCore/animation/WebAnimation.h:

Canonical link: https://commits.webkit.org/284777@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications