[webkit-changes] [WebKit/WebKit] 0871eb: Remove HighlightAPIEnabled and GrammarAndSpellingP...

Tim Nguyen noreply at github.com
Mon Oct 7 11:03:29 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0871eb9a2c025797729178bb10d20d38d82e682b
      https://github.com/WebKit/WebKit/commit/0871eb9a2c025797729178bb10d20d38d82e682b
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
    M LayoutTests/highlight/highlight-crash.html
    M LayoutTests/highlight/highlight-interfaces.html
    M LayoutTests/highlight/highlight-map-and-group.html
    M LayoutTests/highlight/highlight-pseudo-element-style.html
    M LayoutTests/highlight/highlight-world-leak.html
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/Modules/highlight/Highlight.idl
    M Source/WebCore/Modules/highlight/HighlightRegistry.idl
    M Source/WebCore/css/CSSPseudoSelectors.json
    M Source/WebCore/css/DOMCSSNamespace.idl
    M Source/WebCore/css/parser/CSSParserContext.cpp
    M Source/WebCore/css/parser/CSSParserContext.h
    M Source/WebCore/css/parser/CSSSelectorParserContext.cpp
    M Source/WebCore/css/parser/CSSSelectorParserContext.h
    M Source/WebCore/rendering/MarkedText.cpp
    M Source/WebCore/rendering/RenderReplaced.cpp
    M Source/WebKit/UIProcess/API/C/WKPreferences.cpp
    M Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
    M Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
    M Source/WebKitLegacy/mac/WebView/WebPreferences.mm
    M Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
    M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp

  Log Message:
  -----------
  Remove HighlightAPIEnabled and GrammarAndSpellingPseudoElementsEnabled flags
https://bugs.webkit.org/show_bug.cgi?id=280913
rdar://137312546

Reviewed by Anne van Kesteren.

These have been enabled for almost a year now. Remove them to free up bits.

* LayoutTests/highlight/highlight-crash.html:
* LayoutTests/highlight/highlight-interfaces.html:
* LayoutTests/highlight/highlight-map-and-group.html:
* LayoutTests/highlight/highlight-pseudo-element-style.html:
* LayoutTests/highlight/highlight-world-leak.html:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Modules/highlight/Highlight.idl:
* Source/WebCore/Modules/highlight/HighlightRegistry.idl:
* Source/WebCore/css/CSSPseudoSelectors.json:
* Source/WebCore/css/DOMCSSNamespace.idl:
* Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::add):
* Source/WebCore/css/parser/CSSParserContext.h:
* Source/WebCore/css/parser/CSSSelectorParserContext.cpp:
(WebCore::CSSSelectorParserContext::CSSSelectorParserContext):
(WebCore::add):
* Source/WebCore/css/parser/CSSSelectorParserContext.h:
* Source/WebCore/rendering/MarkedText.cpp:
(WebCore::MarkedText::collectForHighlights):
(WebCore::MarkedText::collectForDocumentMarkers):
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::calculateHighlightColor const):
* Source/WebKit/UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetHighlightAPIEnabled):
(WKPreferencesGetHighlightAPIEnabled):
* Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:
* Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h:
* Source/WebKitLegacy/mac/WebView/WebPreferences.mm:
(-[WebPreferences highlightAPIEnabled]):
(-[WebPreferences setHighlightAPIEnabled:]):
* Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitFeatures):

Canonical link: https://commits.webkit.org/284769@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list