[webkit-changes] [WebKit/WebKit] 7ce258: CoreAudioSharedUnit should reset its muted state w...

youennf noreply at github.com
Mon Oct 7 10:41:38 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7ce25896330153d19547da8459f9901aeddd3247
      https://github.com/WebKit/WebKit/commit/7ce25896330153d19547da8459f9901aeddd3247
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
    M Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp
    M Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.h

  Log Message:
  -----------
  CoreAudioSharedUnit should reset its muted state when restarting
rdar://137423858
https://bugs.webkit.org/show_bug.cgi?id=280973

Reviewed by Eric Carlson.

When stopping capture while muted via AirPods, the muted state is sticky in the device and the audio unit.
When starting capture, we make sure to clear those two flags.
We introduce updateMutedState which is used to mute/unmute when isProducingMicrophoneSamplesChanged changes as well as when starting to capture.

Manually tested.

* Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp:
(WebCore::CoreAudioSharedUnit::startInternal):
(WebCore::CoreAudioSharedUnit::isProducingMicrophoneSamplesChanged):
(WebCore::CoreAudioSharedUnit::updateMutedState):
(WebCore::CoreAudioSharedUnit::stopInternal):
* Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.h:

Canonical link: https://commits.webkit.org/284767@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list