[webkit-changes] [WebKit/WebKit] 7d3dcb: Fix smart pointer warnings in RemoteSourceBufferPr...

Ryosuke Niwa noreply at github.com
Mon Oct 7 01:04:17 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7d3dcb5289b05797610da7432b2f1ca0393570c3
      https://github.com/WebKit/WebKit/commit/7d3dcb5289b05797610da7432b2f1ca0393570c3
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/SourceBufferPrivateClient.h
    M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp
    M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations

  Log Message:
  -----------
  Fix smart pointer warnings in RemoteSourceBufferProxy::createInitializationSegmentInfo
https://bugs.webkit.org/show_bug.cgi?id=280936

Reviewed by Chris Dumez.

The warnings were emitted because static analyzer can't resolve the type of the "auto" lambda arguments.
Explicitly specify the argument type to fix this.

Also protect the media description as it was warned by the static analyzer once the type was specified.

* Source/WebCore/platform/graphics/SourceBufferPrivateClient.h:
(WebCore::SourceBufferPrivateClient::InitializationSegment::AudioTrackInformation::protectedDescription const):
(WebCore::SourceBufferPrivateClient::InitializationSegment::VideoTrackInformation::protectedDescription const):
(WebCore::SourceBufferPrivateClient::InitializationSegment::TextTrackInformation::protectedDescription const):
* Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp:
(WebKit::RemoteSourceBufferProxy::createInitializationSegmentInfo):
* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:

Canonical link: https://commits.webkit.org/284753@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list