[webkit-changes] [WebKit/WebKit] 239674: [FFC] Add support for column-gap value

Alan Baradlay noreply at github.com
Sun Oct 6 20:40:43 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 239674d2ad94ad0c84b4f3a2bdeab75d879279d2
      https://github.com/WebKit/WebKit/commit/239674d2ad94ad0c84b4f3a2bdeab75d879279d2
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-10-06 (Sun, 06 Oct 2024)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.h
    M Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp
    M Source/WebCore/layout/formattingContexts/flex/FlexLayout.h
    M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp

  Log Message:
  -----------
  [FFC] Add support for column-gap value
https://bugs.webkit.org/show_bug.cgi?id=280947

Reviewed by Antti Koivisto.

This is similar to row-gap where we shrink the available space when computing alignment
while offsetting flex items' main position at the final geometry compute.

* Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp:
(WebCore::Layout::FlexFormattingUtils::columnGapValue):
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.h:
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:
(WebCore::Layout::FlexLayout::layout):
(WebCore::Layout::FlexLayout::computeFlexLines const):
(WebCore::Layout::FlexLayout::handleMainAxisAlignment const):
(WebCore::Layout::FlexLayout::mainAxisAvailableSpaceForItemAlignment const):
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForFlexLayoutWithReason):
(WebCore::LayoutIntegration::printReason):

Canonical link: https://commits.webkit.org/284748@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list