[webkit-changes] [WebKit/WebKit] e7b4f9: [FFC] Add support for row-gap value

Alan Baradlay noreply at github.com
Sun Oct 6 13:36:27 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e7b4f98ae25b959bbb9c69f0cf14540794868a55
      https://github.com/WebKit/WebKit/commit/e7b4f98ae25b959bbb9c69f0cf14540794868a55
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-10-06 (Sun, 06 Oct 2024)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.h
    M Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp
    M Source/WebCore/layout/formattingContexts/flex/FlexLayout.h
    M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp

  Log Message:
  -----------
  [FFC] Add support for row-gap value
https://bugs.webkit.org/show_bug.cgi?id=280943

Reviewed by Antti Koivisto.

Shrink the available cross space for flex lines and adjust the final
cross axis line position with the row-gap value.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp:
(WebCore::Layout::FlexFormattingUtils::isMainAxisParallelWithInlineAxis):
(WebCore::Layout::FlexFormattingUtils::isMainReversedToContentDirection):
(WebCore::Layout::FlexFormattingUtils::areFlexLinesReversedInCrossAxis):
(WebCore::Layout::FlexFormattingUtils::rowGapValue):
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.h:
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:
(WebCore::Layout::FlexLayout::layout):
(WebCore::Layout::FlexLayout::stretchFlexLines const):
(WebCore::Layout::FlexLayout::handleCrossAxisAlignmentForFlexLines const):
(WebCore::Layout::FlexLayout::crossAxisAvailableSpaceForLineSizingAndAlignment const):
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForFlexLayoutWithReason):
(WebCore::LayoutIntegration::printReason):

Canonical link: https://commits.webkit.org/284743@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list