[webkit-changes] [WebKit/WebKit] 0e415f: [FFC][Cleanup] Remove redundant flex box constrain...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0e415f226f82bbca97fc1ea952294308fd998e5a
      https://github.com/WebKit/WebKit/commit/0e415f226f82bbca97fc1ea952294308fd998e5a
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-10-06 (Sun, 06 Oct 2024)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingConstraints.h
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp
    M Source/WebCore/layout/formattingContexts/flex/FlexLayout.h

  Log Message:
  -----------
  [FFC][Cleanup] Remove redundant flex box constraint parameters (and rename)
https://bugs.webkit.org/show_bug.cgi?id=280942

Reviewed by Antti Koivisto.

Some of these values are going to be computed in the integration codepath (e.g. isSizedUnderMinMaxConstraint) and some are not needed at all.

* Source/WebCore/layout/formattingContexts/flex/FlexFormattingConstraints.h:
(WebCore::Layout::ConstraintsForFlexContent::isSizedUnderMinMax const):
(WebCore::Layout::ConstraintsForFlexContent::ConstraintsForFlexContent):
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layout):
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:
(WebCore::Layout::FlexLayout::layout):
(WebCore::Layout::FlexLayout::maxContentForFlexItem const):
(WebCore::Layout::FlexLayout::flexBaseAndHypotheticalMainSizeForFlexItems const):
(WebCore::Layout::FlexLayout::flexContainerInnerMainSize const):
(WebCore::Layout::FlexLayout::computeFlexLines const):
(WebCore::Layout::FlexLayout::computeMainSizeForFlexItems const):
(WebCore::Layout::FlexLayout::crossSizeForFlexLines const):
(WebCore::Layout::FlexLayout::stretchFlexLines const):
(WebCore::Layout::FlexLayout::handleCrossAxisAlignmentForFlexLines const):
(WebCore::Layout::FlexLayout::computeAvailableMainAndCrossSpace): Deleted.
(WebCore::Layout::FlexLayout::maxContentForFlexItem): Deleted.
(WebCore::Layout::FlexLayout::flexBaseAndHypotheticalMainSizeForFlexItems): Deleted.
(WebCore::Layout::FlexLayout::flexContainerMainSize const): Deleted.
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:

Canonical link: https://commits.webkit.org/284741@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications