[webkit-changes] [WebKit/WebKit] 799cdf: REGRESSION(282648 at main): Speedometer 3.0 test Todo...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 799cdf9de44ee39ead5468f13300884f4bc43f8e
      https://github.com/WebKit/WebKit/commit/799cdf9de44ee39ead5468f13300884f4bc43f8e
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2024-10-05 (Sat, 05 Oct 2024)

  Changed paths:
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/Element.h

  Log Message:
  -----------
  REGRESSION(282648 at main): Speedometer 3.0 test TodoMVC-JavaScript-ES6-Webpack-Complex-DOM was regressed
https://bugs.webkit.org/show_bug.cgi?id=279216
rdar://134688490

Reviewed by Ryosuke Niwa.

If an element, without children and without shadowRoot, is insertedIntoAncestor()
don't call updateEffectiveTextDirection() since it is expensive call. In this
case just, set the bit setEffectiveTextDirection(). To make this change clean,
add the new method updateEffectiveTextDirectionIfNeeded() and call it from
insertedIntoAncestor().

* Source/WebCore/dom/Element.cpp:
(WebCore::Element::updateEffectiveTextDirectionIfNeeded):
(WebCore::Element::insertedIntoAncestor):
* Source/WebCore/dom/Element.h:

Canonical link: https://commits.webkit.org/284731@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications