[webkit-changes] [WebKit/WebKit] 6a9a05: Provide a swift implementation for CommandEncoder:...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6a9a052fc36c271ed249b88a35d652594a5107c7
      https://github.com/WebKit/WebKit/commit/6a9a052fc36c271ed249b88a35d652594a5107c7
  Author: Nitin Mahendru <nitinmahendru at apple.com>
  Date:   2024-10-04 (Fri, 04 Oct 2024)

  Changed paths:
    M Source/WTF/wtf/text/WTFString.h
    M Source/WebGPU/WebGPU.xcodeproj/project.pbxproj
    M Source/WebGPU/WebGPU/CommandEncoder.h
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    A Source/WebGPU/WebGPU/CommandEncoder.swift
    M Source/WebGPU/WebGPU/CommandsMixin.h
    M Source/WebGPU/WebGPU/Device.h
    M Source/WebGPU/WebGPU/Device.mm
    M Source/WebGPU/WebGPU/Queue.swift
    M Source/WebGPU/WebGPU/WebGPUExt.h

  Log Message:
  -----------
  Provide a swift implementation for CommandEncoder::clearBuffer
https://bugs.webkit.org/show_bug.cgi?id=280767
rdar://137134098

Reviewed by Mike Wyrzykowski.

It's a 1 to 1 replacement of the Obj-C version.

Testing:
compile with make release BUILD_WEBKIT_OPTIONS="--webGpuSwift".
Then run:
1. http/tests/webgpu/webgpu/api/validation/encoding/cmds/clearBuffer.html
2. http/tests/webgpu/webgpu/api/operation/command_buffer/clearBuffer.html

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebGPU/WebGPU.xcodeproj/project.pbxproj:
* Source/WebGPU/WebGPU/CommandEncoder.h:
(retainCommandEncoder):
(releaseCommandEncoder):
(WebGPU::CommandEncoder::device const): Deleted.
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::generateInvalidEncoderStateError):
(WebGPU::CommandEncoder::clearBuffer):
* Source/WebGPU/WebGPU/CommandEncoder.swift: Copied from Source/WebGPU/WebGPU/CommandsMixin.h.
(clearBuffer(_:buffer:offset:size:)):
(WebGPU.clearBuffer(_:offset:size:)):
* Source/WebGPU/WebGPU/CommandsMixin.h:
* Source/WebGPU/WebGPU/Device.h:
* Source/WebGPU/WebGPU/Device.mm:
(WebGPU::Device::generateAValidationError):
* Source/WebGPU/WebGPU/WebGPUExt.h:

Canonical link: https://commits.webkit.org/284713@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications