[webkit-changes] [WebKit/WebKit] e03955: [WebIDL] Add support for undefined in union

Sihui noreply at github.com
Fri Oct 4 11:19:10 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e039559cfde3eaa9d0b9fdb24341311e879f63bc
      https://github.com/WebKit/WebKit/commit/e039559cfde3eaa9d0b9fdb24341311e879f63bc
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-10-04 (Fri, 04 Oct 2024)

  Changed paths:
    M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
    M Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.cpp
    M Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.h
    M Source/WebCore/css/typedom/StylePropertyMapReadOnly.h
    M Source/WebCore/css/typedom/StylePropertyMapReadOnly.idl

  Log Message:
  -----------
  [WebIDL] Add support for undefined in union
https://bugs.webkit.org/show_bug.cgi?id=280814
rdar://137182423

Reviewed by Chris Dumez.

Use IDLNull (underlying type std::nullptr_t) instead of IDLUndefined (underlying type void) for undefined in IDLUnion
(underlying type std::variant), because std::variant cannot hold type void.

* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GetNumberOfNullableMemberTypes):
(GetIDLUnionMemberTypes):
* Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.cpp:
(WebCore::MainThreadStylePropertyMapReadOnly::get const):
(WebCore::MainThreadStylePropertyMapReadOnly::has const):
* Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.h:
* Source/WebCore/css/typedom/StylePropertyMapReadOnly.h:
* Source/WebCore/css/typedom/StylePropertyMapReadOnly.idl:

Canonical link: https://commits.webkit.org/284691@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list