[webkit-changes] [WebKit/WebKit] 350809: [Table] Remove legacy behavior where baseline alig...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 35080913a8857664e7d08a58b8739c64a71e4098
      https://github.com/WebKit/WebKit/commit/35080913a8857664e7d08a58b8739c64a71e4098
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-10-04 (Fri, 04 Oct 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-tables/tentative/baseline-td-expected.txt
    M LayoutTests/platform/ios/fast/multicol/table-vertical-align-expected.txt
    M LayoutTests/platform/ios/fast/table/vertical-align-baseline-expected.txt
    M LayoutTests/platform/ios/tables/mozilla/bugs/bug10296-1-expected.txt
    M LayoutTests/platform/ios/tables/mozilla/marvin/tbody_valign_baseline-expected.txt
    M LayoutTests/platform/ios/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt
    M LayoutTests/platform/ios/tables/mozilla/marvin/thead_valign_baseline-expected.txt
    M LayoutTests/platform/ios/tables/mozilla/marvin/tr_valign_baseline-expected.txt
    M LayoutTests/platform/ios/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt
    M LayoutTests/platform/mac-ventura/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt
    M LayoutTests/platform/mac/fast/multicol/table-vertical-align-expected.txt
    M LayoutTests/platform/mac/fast/table/vertical-align-baseline-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug10296-1-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/marvin/tbody_valign_baseline-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/marvin/thead_valign_baseline-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/marvin/tr_valign_baseline-expected.txt
    M LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt
    M Source/WebCore/rendering/RenderTableSection.cpp

  Log Message:
  -----------
  [Table] Remove legacy behavior where baseline aligned content stretches the row
https://bugs.webkit.org/show_bug.cgi?id=280861

Reviewed by Antti Koivisto.

Alignment is not meant to be base for sizing and yet table rows are getting stretched
by their baseline aligned content (but only baseline).

This change makes us aligned with Blink.

* LayoutTests/imported/w3c/web-platform-tests/css/css-tables/tentative/baseline-td-expected.txt:
* LayoutTests/platform/mac/fast/table/vertical-align-baseline-expected.txt:
* Source/WebCore/rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight): Remove logic that inflates row height when baseline is outside of the border box.

Canonical link: https://commits.webkit.org/284680@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications