[webkit-changes] [WebKit/WebKit] 6230d0: Flip hi/lo to lo/hi in LowerInt64 and related code

[aoikonomopoulos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6230d08a66f31deb1424750b12cb5eefb3eef881
      https://github.com/WebKit/WebKit/commit/6230d08a66f31deb1424750b12cb5eefb3eef881
  Author: Angelos Oikonomopoulos <angelos at igalia.com>
  Date:   2024-10-04 (Fri, 04 Oct 2024)

  Changed paths:
    M Source/JavaScriptCore/b3/B3ExtractValue.h
    M Source/JavaScriptCore/b3/B3LowerInt64.cpp
    M Source/JavaScriptCore/b3/B3LowerToAir32_64.cpp
    M Source/JavaScriptCore/b3/air/AirCCallingConvention.cpp
    M Source/JavaScriptCore/wasm/WasmOMGIRGenerator32_64.cpp

  Log Message:
  -----------
  Flip hi/lo to lo/hi in LowerInt64 and related code
https://bugs.webkit.org/show_bug.cgi?id=280826

Reviewed by Justin Michaud.

AirCCallingConvention allocates registers in order, so passing the low
bits of an Int64 avoids the need to massage things. However, we want to
have a consistent order in all related code to avoid silly mistakes, so
this changes everything other than the assembler to use lo, hi ordering.

* Source/JavaScriptCore/b3/B3ExtractValue.h:
* Source/JavaScriptCore/b3/B3LowerInt64.cpp:
* Source/JavaScriptCore/b3/B3LowerToAir32_64.cpp:
* Source/JavaScriptCore/b3/air/AirCCallingConvention.cpp:
(JSC::B3::Air::ArgumentValueList::makeStitch const):
(JSC::B3::Air::ArgumentValueList::makeCCallValue const):
* Source/JavaScriptCore/wasm/WasmOMGIRGenerator32_64.cpp:
(JSC::Wasm::OMGIRGenerator::addArguments):
(JSC::Wasm::OMGIRGenerator::emitIndirectCall):
(JSC::Wasm::OMGIRGenerator::addCall):

Canonical link: https://commits.webkit.org/284674@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications