[webkit-changes] [WebKit/WebKit] 82e54e: [scroll-animations] update `AnimationEffectTiming`...

Antoine Quint noreply at github.com
Fri Oct 4 01:00:05 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 82e54eaf31dbcf921a25b93e0751869a876bd04f
      https://github.com/WebKit/WebKit/commit/82e54eaf31dbcf921a25b93e0751869a876bd04f
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-10-04 (Fri, 04 Oct 2024)

  Changed paths:
    M Source/WebCore/animation/AnimationEffect.cpp
    M Source/WebCore/animation/AnimationEffect.h
    M Source/WebCore/animation/AnimationEffectTiming.cpp
    M Source/WebCore/animation/AnimationEffectTiming.h
    M Source/WebCore/animation/BasicEffectTiming.h
    M Source/WebCore/animation/CSSNumberishTime.cpp
    M Source/WebCore/animation/CSSNumberishTime.h
    M Source/WebCore/animation/KeyframeEffect.cpp
    M Source/WebCore/animation/KeyframeInterpolation.cpp
    M Source/WebCore/animation/KeyframeInterpolation.h
    M Source/WebCore/animation/StyleOriginatedAnimation.cpp
    M Source/WebCore/animation/WebAnimation.cpp
    M Source/WebCore/animation/WebAnimation.h
    M Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  -----------
  [scroll-animations] update `AnimationEffectTiming` and `BasicEffectTiming` to use `CSSNumberishTime`
https://bugs.webkit.org/show_bug.cgi?id=280823
rdar://137200964

Reviewed by Cameron McCormack.

We refactor yet more code backing timing computations to `CSSNumberishTime` instead of `Seconds`,
paving the way to supporting percentage values for Scroll-driven Animations.

* Source/WebCore/animation/AnimationEffect.cpp:
(WebCore::durationAPIValue):
(WebCore::AnimationEffect::getBindingsTiming const):
(WebCore::AnimationEffect::getComputedTiming const):
* Source/WebCore/animation/AnimationEffect.h:
(WebCore::AnimationEffect::iterationDuration const):
(WebCore::AnimationEffect::activeDuration const):
(WebCore::AnimationEffect::endTime const):
* Source/WebCore/animation/AnimationEffectTiming.cpp:
(WebCore::AnimationEffectTiming::updateComputedProperties):
(WebCore::AnimationEffectTiming::getBasicTiming const):
(WebCore::AnimationEffectTiming::resolve const):
* Source/WebCore/animation/AnimationEffectTiming.h:
* Source/WebCore/animation/BasicEffectTiming.h:
* Source/WebCore/animation/CSSNumberishTime.cpp:
(WebCore::CSSNumberishTime::CSSNumberishTime):
(WebCore::CSSNumberishTime::isInfinity const):
(WebCore::CSSNumberishTime::isZero const):
(WebCore::CSSNumberishTime::approximatelyEqualTo const):
(WebCore::CSSNumberishTime::operator/ const):
* Source/WebCore/animation/CSSNumberishTime.h:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::backingAnimationForCompositedRenderer const):
* Source/WebCore/animation/KeyframeInterpolation.cpp:
(WebCore::transformProgressDuration):
(WebCore::KeyframeInterpolation::interpolateKeyframes const):
* Source/WebCore/animation/KeyframeInterpolation.h:
* Source/WebCore/animation/StyleOriginatedAnimation.cpp:
(WebCore::StyleOriginatedAnimation::invalidateDOMEvents):
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::zeroTime const):
(WebCore::WebAnimation::effectEndTime const):
(WebCore::WebAnimation::finish):
(WebCore::WebAnimation::updateFinishedState):
(WebCore::WebAnimation::pause):
* Source/WebCore/animation/WebAnimation.h:
* Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp:
(WebCore::buildObjectForEffect):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/284666@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list