[webkit-changes] [WebKit/WebKit] 3b34f7: Fix drag previews to disappear when cancelling dra...

[Jessica Cheung]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3b34f7ad517885f6901fc173cba6445c65ad3f6f
      https://github.com/WebKit/WebKit/commit/3b34f7ad517885f6901fc173cba6445c65ad3f6f
  Author: Jessica Cheung <jcheung23 at apple.com>
  Date:   2024-10-03 (Thu, 03 Oct 2024)

  Changed paths:
    M Source/WebKit/UIProcess/ios/DragDropInteractionState.h
    M Source/WebKit/UIProcess/ios/DragDropInteractionState.mm
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  Fix drag previews to disappear when cancelling drag in Safari
https://bugs.webkit.org/show_bug.cgi?id=280854
rdar://136328215

Reviewed by Wenson Hsieh.

Currently, drag previews remain on the screen because we do not remove
all of the previews from the view hierarchy.
This is fixed by having a vector of views to be removed instead of just one view.

* Source/WebKit/UIProcess/ios/DragDropInteractionState.h:
(WebKit::DragDropInteractionState::takePreviewViewsForDragCancel):
(WebKit::DragDropInteractionState::takePreviewViewForDragCancel): Deleted.
* Source/WebKit/UIProcess/ios/DragDropInteractionState.mm:
(WebKit::DragDropInteractionState::previewForCancelling):
(WebKit::DragDropInteractionState::dragAndDropSessionsDidBecomeInactive):
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView dragInteraction:item:willAnimateCancelWithAnimator:]):

Canonical link: https://commits.webkit.org/284657@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications