[webkit-changes] [WebKit/WebKit] 00b6cb: REGRESSION: 282146 at main made text entry in a quip ...

Chris Dumez noreply at github.com
Thu Oct 3 15:40:15 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 00b6cbd15cad451e4d5691f32554e8802d422552
      https://github.com/WebKit/WebKit/commit/00b6cbd15cad451e4d5691f32554e8802d422552
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-10-03 (Thu, 03 Oct 2024)

  Changed paths:
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Document.h

  Log Message:
  -----------
  REGRESSION: 282146 at main made text entry in a quip document very slow
https://bugs.webkit.org/show_bug.cgi?id=280827
rdar://137203711

Reviewed by Ryosuke Niwa.

Call WeakHashSet::isEmptyIgnoringNullReferences() instead of WeakHashSet::computeSize()
whenever possible. computeSize() forces the cleanup of the WeakHashSet, while
isEmptyIgnoringNullReferences() doesn't.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::willBeRemovedFromFrame):
* Source/WebCore/dom/Document.h:
(WebCore::Document::hasTouchEventHandlers const):
(WebCore::Document::hasWheelEventHandlers const):

Canonical link: https://commits.webkit.org/284643@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list