[webkit-changes] [WebKit/WebKit] 26880c: Swift Implementation for underlying Queue::writeBu...
Commit Queue
noreply at github.com
Thu Oct 3 14:38:39 PDT 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 26880c142f2708a75e519e311edf1b99e9ab208b
https://github.com/WebKit/WebKit/commit/26880c142f2708a75e519e311edf1b99e9ab208b
Author: Nitin Mahendru <nitinmahendru at apple.com>
Date: 2024-10-03 (Thu, 03 Oct 2024)
Changed paths:
M Source/WTF/wtf/RefCounted.h
M Source/WTF/wtf/RetainReleaseSwift.h
M Source/WTF/wtf/ThreadSafeRefCounted.h
M Source/WTF/wtf/ThreadSafeWeakPtr.h
M Source/WebGPU/WebGPU.xcodeproj/project.pbxproj
M Source/WebGPU/WebGPU/Buffer.h
M Source/WebGPU/WebGPU/Device.h
M Source/WebGPU/WebGPU/Queue.h
M Source/WebGPU/WebGPU/Queue.mm
M Source/WebGPU/WebGPU/Queue.swift
M Source/WebGPU/WebGPU/WebGPUExt.h
Log Message:
-----------
Swift Implementation for underlying Queue::writeBuffer
https://bugs.webkit.org/show_bug.cgi?id=280715
rdar://136672126
Reviewed by Mike Wyrzykowski.
Re-implement Queue::writeBuffer using a Swift implementation.
It is still using some underlying utilities from the C++ implementation
but that can only be moved over once Swift implements the whole class and has ownership
of underlying objects.
Testing:
Manual at desk builds with --webGpuSwift and running the Buffer and Queue tests.
Then Run writeBuffer.html test.
* Source/WTF/wtf/RefCounted.h:
(retainRefCounted): Deleted.
(releaseRefCounted): Deleted.
* Source/WTF/wtf/RetainReleaseSwift.h:
* Source/WTF/wtf/ThreadSafeRefCounted.h:
(retainThreadSafeRefCounted): Deleted.
(releaseThreadSafeRefCounted): Deleted.
* Source/WTF/wtf/ThreadSafeWeakPtr.h:
(WTF::retainThreadSafeRefCountedAndCanMakeThreadSafeWeakPtr):
(WTF::releaseThreadSafeRefCountedAndCanMakeThreadSafeWeakPtr):
* Source/WebGPU/WebGPU.xcodeproj/project.pbxproj:
* Source/WebGPU/WebGPU/Buffer.h:
(retainBuffer):
(releaseBuffer):
* Source/WebGPU/WebGPU/Device.h:
(retainDevice):
(releaseDevice):
* Source/WebGPU/WebGPU/Queue.h:
(WebGPU::Queue::blitCommandEncoder):
(retainQueue):
(releaseQueue):
* Source/WebGPU/WebGPU/Queue.swift:
(WebGPU.writeBuffer(_:bufferOffset:data:)):
(writeBuffer(_:buffer:offset:data:)): Deleted.
* Source/WebGPU/WebGPU/WebGPUExt.h:
Canonical link: https://commits.webkit.org/284638@main
To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications
More information about the webkit-changes
mailing list