[webkit-changes] [WebKit/WebKit] 1e783c: [scroll-animations] update `EffectTiming.duration`...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1e783c0e6d6a20328d171fcbfcc91384ddb0c263
      https://github.com/WebKit/WebKit/commit/1e783c0e6d6a20328d171fcbfcc91384ddb0c263
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-10-03 (Thu, 03 Oct 2024)

  Changed paths:
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/animation/CustomEffect.cpp
    A Source/WebCore/animation/EffectTiming.cpp
    M Source/WebCore/animation/EffectTiming.h
    M Source/WebCore/animation/EffectTiming.idl
    M Source/WebCore/animation/KeyframeEffect.cpp

  Log Message:
  -----------
  [scroll-animations] update `EffectTiming.duration` to use `CSSNumberish`
https://bugs.webkit.org/show_bug.cgi?id=279728
rdar://136031070

Reviewed by Tim Nguyen.

Add CSSNumericValue as one of the options for `EffectTiming.duration`. Since percentage
values are not allowed as input, we add the `EffectTiming::durationAsDoubleOrString()`
to convert this value for the `double` and `DOMString` case.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/CustomEffect.cpp:
(WebCore::CustomEffect::create):
* Source/WebCore/animation/EffectTiming.cpp: Added.
(WebCore::EffectTiming::durationAsDoubleOrString const):
* Source/WebCore/animation/EffectTiming.h:
* Source/WebCore/animation/EffectTiming.idl:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::create):

Canonical link: https://commits.webkit.org/284623@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications