[webkit-changes] [WebKit/WebKit] 77d74f: AX: need to handle dynamically-created and nested ...

[Dominic Mazzoni]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 77d74fdb4d16d5bcf79cf7a270b7e2dcbaf3799f
      https://github.com/WebKit/WebKit/commit/77d74fdb4d16d5bcf79cf7a270b7e2dcbaf3799f
  Author: Dominic Mazzoni <dm_mazzoni at apple.com>
  Date:   2024-10-03 (Thu, 03 Oct 2024)

  Changed paths:
    A LayoutTests/accessibility/mac/dynamic-modal-expected.txt
    A LayoutTests/accessibility/mac/dynamic-modal.html
    A LayoutTests/accessibility/mac/nested-modal-expected.txt
    A LayoutTests/accessibility/mac/nested-modal.html
    M Source/WebCore/accessibility/AXObjectCache.cpp

  Log Message:
  -----------
  AX: need to handle dynamically-created and nested aria-modal dialogs
https://bugs.webkit.org/show_bug.cgi?id=280643
rdar://137000722

Reviewed by Tyler Wilcock.

In isolated tree mode, WebKit wasn't properly handling the case where
an aria-modal dialog is dynamically created and added to the DOM.  In
addition, WebKit didn't have any logic to pick the deepest aria-modal
dialog if multiple dialogs are nested. Adding this logic matches
Chrome's behavior now.  In both cases, the issue was correctly
ignoring everything outside of the dialog while focus is inside.

* LayoutTests/accessibility/mac/dynamic-modal-expected.txt: Added.
* LayoutTests/accessibility/mac/dynamic-modal.html: Added.
* LayoutTests/accessibility/mac/nested-modal-expected.txt: Added.
* LayoutTests/accessibility/mac/nested-modal.html: Added.
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::updateCurrentModalNode):
(WebCore::AXObjectCache::handleAttributeChange):

Canonical link: https://commits.webkit.org/284613@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications