[webkit-changes] [WebKit/WebKit] ba0327: [Static Analyzer CI] Add step to update clang on w...

Brianna Fan noreply at github.com
Wed Oct 2 14:13:41 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ba0327a7a34f728c64cf5febdbba1f02fb0abb33
      https://github.com/WebKit/WebKit/commit/ba0327a7a34f728c64cf5febdbba1f02fb0abb33
  Author: Brianna Fan <bfan2 at apple.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M Tools/CISupport/ews-build/factories.py
    M Tools/CISupport/ews-build/factories_unittest.py
    M Tools/CISupport/ews-build/steps.py
    M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  -----------
  [Static Analyzer CI] Add step to update clang on worker
https://bugs.webkit.org/show_bug.cgi?id=280306
rdar://136511492

Reviewed by Jonathan Bedard.

Frequent changes are being made to the checks so having an automatic system to update
the workers will save a lot of engineering time.

In the future, we just need to update LLVM_REVISION to build on the desired change.

* Tools/CISupport/ews-build/factories.py:
(SmartPointerStaticAnalyzerFactory.__init__):

* Tools/CISupport/ews-build/steps.py:
(CheckOutLLVMProject):
    Modelled very closely after CheckoutSource. This step will check if the current
    clang version matches the desired revision. If not, it will check out the desired revision.
(CheckOutLLVMProject.__init__):
(CheckOutLLVMProject.run_vc):
(CheckOutLLVMProject.parseGotRevision):
(CheckOutLLVMProject.getResultSummary):

(UpdateClang):
    This step will build clang if the current clang version doesn't match the desired revision.
    We must delete WebKitBuild for a clean build, otherwise the build will fail.
    If the build is not successful, we resort to the previous clang if there is one.
    If there is none, we retry the build.
(UpdateClang.__init__):
(UpdateClang.run):
(UpdateClang.doStepIf):
(UpdateClang.getResultSummary):

(PrintClangVersionAfterUpdate):
    Added after a successful clang update. This will print the new version and switch the build directory
    with the new one.
(PrintClangVersionAfterUpdate.run):
(PrintClangVersionAfterUpdate.getResultSummary):
* Tools/CISupport/ews-build/steps_unittest.py:

* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/284576@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list