[webkit-changes] [WebKit/WebKit] 01c06e: JSDOMPromiseDeferred.h:307:20: "error: use 'templa...

Abrar Rahman Protyasha noreply at github.com
Wed Oct 2 08:45:12 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 01c06ea002c2b91b1025709161885049b5a296c7
      https://github.com/WebKit/WebKit/commit/01c06ea002c2b91b1025709161885049b5a296c7
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M Source/WebCore/bindings/js/JSDOMPromiseDeferred.h

  Log Message:
  -----------
  JSDOMPromiseDeferred.h:307:20: "error: use 'template' keyword to treat 'resolve' as a dependent template name" with some Clang versions
https://bugs.webkit.org/show_bug.cgi?id=280744
rdar://136932730

Reviewed by Darin Adler.

In some Clang versions, we get the following error diagnostic:

```
JSDOMPromiseDeferred.h:307:20: error: use 'template' keyword to treat 'resolve' as a dependent template name
  307 |         m_promise->resolve<IDLType>(std::forward<typename IDLType::ParameterType>(value));
      |                    ^
      |                    template
```

This is a valid error because `m_promise` is indeed a member template
specialization and the `resolve()` call explicitly depends on a template
parameter.

We fix this by prepending the `resolve()` call with keyword `template`.

c.f. ISO C++23 13.3.3.4.

* Source/WebCore/bindings/js/JSDOMPromiseDeferred.h:
(WebCore::DOMPromiseDeferred::resolve):

Canonical link: https://commits.webkit.org/284560@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list