[webkit-changes] [WebKit/WebKit] 7cd834: Use CheckedRef in QueryContainerUpdateContext

Antti Koivisto noreply at github.com
Wed Oct 2 06:02:38 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7cd83453f659a0f6cc232315ac924b279b4f2de5
      https://github.com/WebKit/WebKit/commit/7cd83453f659a0f6cc232315ac924b279b4f2de5
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M Source/WebCore/style/StyleScope.cpp
    M Source/WebCore/style/StyleScope.h

  Log Message:
  -----------
  Use CheckedRef in QueryContainerUpdateContext
https://bugs.webkit.org/show_bug.cgi?id=280723
rdar://137092491

Reviewed by Chris Dumez.

Fix the issue seen in https://commits.webkit.org/268375@main and re-introduce CheckedRef.
Tested by fast/dom/Node/Node-destruction-crash.html.

* Source/WebCore/style/StyleScope.cpp:
(WebCore::Style::Scope::updateQueryContainerState):

PseudoElements are not real Elements and can go away during style resolution.
Invalidation logic works on real elements so replace them with their host.

* Source/WebCore/style/StyleScope.h:

Canonical link: https://commits.webkit.org/284557@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list