[webkit-changes] [WebKit/WebKit] 4d33c9: [WPE][Debug] ASSERTION FAILED: canSafelyBeUsed()

Carlos Garcia Campos noreply at github.com
Wed Oct 2 03:57:46 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4d33c93bc32ae08a7958a1c59d59f13a06d18e39
      https://github.com/WebKit/WebKit/commit/4d33c93bc32ae08a7958a1c59d59f13a06d18e39
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/libwpe/AcceleratedSurfaceLibWPE.cpp
    M Source/WebKit/WebProcess/WebPage/libwpe/AcceleratedSurfaceLibWPE.h

  Log Message:
  -----------
  [WPE][Debug] ASSERTION FAILED: canSafelyBeUsed()
https://bugs.webkit.org/show_bug.cgi?id=280617

Reviewed by Chris Dumez.

Save the host file descriptor on AcceleratedSurfaceLibWPE constructor
that is called in the main thread. In initialize(), called from the
compositor thread when the GL context is created, we can release the
file descriptor passing the ownership to the backend.

* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/libwpe/AcceleratedSurfaceLibWPE.cpp:
(WebKit::AcceleratedSurfaceLibWPE::AcceleratedSurfaceLibWPE):
(WebKit::AcceleratedSurfaceLibWPE::initialize):
* Source/WebKit/WebProcess/WebPage/libwpe/AcceleratedSurfaceLibWPE.h:

Canonical link: https://commits.webkit.org/284554@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list