[webkit-changes] [WebKit/WebKit] a14f55: Fix smart pointer warnings in DrawControlPart::apply

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a14f55c42bb5c94d721885c265036b2cde2b6461
      https://github.com/WebKit/WebKit/commit/a14f55c42bb5c94d721885c265036b2cde2b6461
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/controls/ControlPart.cpp
    M Source/WebCore/platform/graphics/controls/ControlPart.h

  Log Message:
  -----------
  Fix smart pointer warnings in DrawControlPart::apply
https://bugs.webkit.org/show_bug.cgi?id=280738

Reviewed by Wenson Hsieh and Andy Estes.

284531 at main fixed member variable warning but introduced uncounted call argument warnings
in DrawControlPart::apply because ControlPart::setOverrideControlFactory is now
considered non-trivial as it's no longer inlined.

Inline ControlPart::setOverrideControlFactory in the header to make it trivial again.

* Source/WebCore/platform/graphics/controls/ControlPart.cpp:
(WebCore::ControlPart::setOverrideControlFactory): Deleted.
* Source/WebCore/platform/graphics/controls/ControlPart.h:
(WebCore::ControlPart::setOverrideControlFactory):

Canonical link: https://commits.webkit.org/284548@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications