[webkit-changes] [WebKit/WebKit] c4a3d3: [WebGPU] Debug assertion in RenderBundleEncoder::c...

mwyrzykowski noreply at github.com
Tue Oct 1 21:20:58 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c4a3d3b51a46f30c0e200e436d1af427f6ba9554
      https://github.com/WebKit/WebKit/commit/c4a3d3b51a46f30c0e200e436d1af427f6ba9554
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-10-01 (Tue, 01 Oct 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/nocrash/fuzz-279693-expected.txt
    A LayoutTests/fast/webgpu/nocrash/fuzz-279693.html
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm

  Log Message:
  -----------
  [WebGPU] Debug assertion in RenderBundleEncoder::currentRenderCommand() fails when RenderBundle has zero commands
https://bugs.webkit.org/show_bug.cgi?id=279693
radar://135708146

Reviewed by Tadeu Zagallo.

When commandCount is zero, we would replay the first recorded operation
when that was not needed, triggering the debug assertion in currentRenderCommand()

* LayoutTests/fast/webgpu/nocrash/fuzz-279693-expected.txt: Added.
* LayoutTests/fast/webgpu/nocrash/fuzz-279693.html: Added.
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::endCurrentICB):

Canonical link: https://commits.webkit.org/284539@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list