[webkit-changes] [WebKit/WebKit] f7058e: [line-clamp] Paginated content rendering fails whe...

Alan Baradlay noreply at github.com
Tue Oct 1 16:14:49 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f7058ef7235e5a099d06a2128285309110345dca
      https://github.com/WebKit/WebKit/commit/f7058ef7235e5a099d06a2128285309110345dca
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-10-01 (Tue, 01 Oct 2024)

  Changed paths:
    A LayoutTests/fast/inline/pagination-and-css-line-clamp-crash-expected.txt
    A LayoutTests/fast/inline/pagination-and-css-line-clamp-crash.html
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp

  Log Message:
  -----------
  [line-clamp] Paginated content rendering fails when line-clamp is present
https://bugs.webkit.org/show_bug.cgi?id=280686
<rdar://135587562>

Reviewed by Antti Koivisto.

1. let's take the starting line index into account when counting the number of lines for line-clamp (starting line index may not be 0 when running partial layout)
2. set the inline content range flag properly when bailing out of line layout as the result of line-clamp discard.

* LayoutTests/fast/inline/pagination-and-css-line-clamp-crash-expected.txt: Added.
* LayoutTests/fast/inline/pagination-and-css-line-clamp-crash.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::lineLayout):

Canonical link: https://commits.webkit.org/284520@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list