[webkit-changes] [WebKit/WebKit] 58ed50: AX: In AccessibilityObject::visibleCharacterRange, ...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 58ed504f03ccef654310f67a8896ab1c40e6cd41
      https://github.com/WebKit/WebKit/commit/58ed504f03ccef654310f67a8896ab1c40e6cd41
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-11-24 (Sun, 24 Nov 2024)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityObject.cpp

  Log Message:
  -----------
  AX: In AccessibilityObject::visibleCharacterRange, we can sometimes loop infinitely over next-line-end positions
https://bugs.webkit.org/show_bug.cgi?id=283640
rdar://140487777

Reviewed by Chris Fleizach.

Based on bug reports, it seems that we can loop infinitely in `AccessibilityObject::visibleCharacterRange()` while trying
to the `nextLineEndPosition`. It would be better if we understood why this happened, but can't reproduce it yet, so for
now just break if `nextLineEndPosition` returns the original position. The ASSERT should help us find a webpage where
this reproduces.

* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::visibleCharacterRangeInternal const):

Canonical link: https://commits.webkit.org/287036@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications