[webkit-changes] [WebKit/WebKit] edf135: REGRESSION(286884 at main?): [macOS Debug] imported/w...

Darin Adler noreply at github.com
Sat Nov 23 03:41:58 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: edf1353f6c6a2cb57eb9f595ba8c32ef721572b5
      https://github.com/WebKit/WebKit/commit/edf1353f6c6a2cb57eb9f595ba8c32ef721572b5
  Author: Darin Adler <darin at apple.com>
  Date:   2024-11-23 (Sat, 23 Nov 2024)

  Changed paths:
    M Source/WebCore/dom/ToggleEventTask.cpp

  Log Message:
  -----------
  REGRESSION(286884 at main?): [macOS Debug] imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic.html is consistent crash(flaky in EWS)
rdar://140385278
https://bugs.webkit.org/show_bug.cgi?id=283537

Reviewed by Tim Nguyen and Ryosuke Niwa.

* Source/WebCore/dom/ToggleEventTask.cpp:
(WebCore::ToggleEventTask::queue): Capture more smart pointers to make
object lifetime more obvious. We no longer are taking advantage of the
"keeping this node alive" behavior, but we're also not accessing anything
that's not through a smart pointer.

Canonical link: https://commits.webkit.org/287005@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list