[webkit-changes] [WebKit/WebKit] 894eb7: Add logging to getNetworkProcessConnection

[bnham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 894eb7d98a31cfa170ee9f0c612c4b956952095d
      https://github.com/WebKit/WebKit/commit/894eb7d98a31cfa170ee9f0c612c4b956952095d
  Author: Ben Nham <nham at apple.com>
  Date:   2024-11-20 (Wed, 20 Nov 2024)

  Changed paths:
    M Source/WebKit/NetworkProcess/NetworkProcess.cpp
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
    M Source/WebKit/WebProcess/WebProcess.cpp

  Log Message:
  -----------
  Add logging to getNetworkProcessConnection
https://bugs.webkit.org/show_bug.cgi?id=283427
rdar://140284484

Reviewed by Per Arne Vollan and Sihui Liu.

We have some hang longs in getNetworkProcessConnection, but even with sysdiags they can be hard to
diagnose because there isn't much logging along the path of this sync IPC from WebProcess =>
UIProcess => NetworkProcess. Add logging to all three call sites and also thread along the core
process identifier so we can link the logs together.

* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::getNetworkProcessConnection):
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::getNetworkProcessConnection):

Canonical link: https://commits.webkit.org/286882@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications