[webkit-changes] [WebKit/WebKit] de32c4: [GTK][Debug] Crash in AudioWorkletMessagingProxy d...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: de32c4a55821aee88b7bed8e605cedb360191bc1
      https://github.com/WebKit/WebKit/commit/de32c4a55821aee88b7bed8e605cedb360191bc1
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/Modules/webaudio/AudioWorkletMessagingProxy.h

  Log Message:
  -----------
  [GTK][Debug] Crash in AudioWorkletMessagingProxy destructor
https://bugs.webkit.org/show_bug.cgi?id=282331

Reviewed by Chris Dumez.

Declare the AudioWorkletMessagingProxy as final, without this, GCC builds hit an ASSERT in the
destructor.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/Modules/webaudio/AudioWorkletMessagingProxy.h:
(WebCore::AudioWorkletMessagingProxy::create): Deleted.
(WebCore::AudioWorkletMessagingProxy::workletThread): Deleted.
(WebCore::AudioWorkletMessagingProxy::checkedPtrCount const): Deleted.
(WebCore::AudioWorkletMessagingProxy::checkedPtrCountWithoutThreadCheck const): Deleted.
(WebCore::AudioWorkletMessagingProxy::incrementCheckedPtrCount const): Deleted.
(WebCore::AudioWorkletMessagingProxy::decrementCheckedPtrCount const): Deleted.

Canonical link: https://commits.webkit.org/286725@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications