[webkit-changes] [WebKit/WebKit] b27353: [LFC][Floats] PlacedFloats's writing mode always m...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b27353f2d6e9b5999fbd09fc21ccb8a9e78abb92
      https://github.com/WebKit/WebKit/commit/b27353f2d6e9b5999fbd09fc21ccb8a9e78abb92
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M Source/WebCore/layout/floats/FloatingContext.cpp
    M Source/WebCore/layout/floats/PlacedFloats.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp

  Log Message:
  -----------
  [LFC][Floats] PlacedFloats's writing mode always matches its block formatting context root's writing mode
https://bugs.webkit.org/show_bug.cgi?id=283230

Reviewed by Antti Koivisto.

1. Remove redundant functions on PlacedFloat (see title)
2. Rename PlacedFloats::formattingContextRoot to blockFormattingContextRoot indicating
that PlacedFloats has to be initiated by BFCs and not just by IFCs.

* SourceformattingContextRoot/WebCore/layout/floats/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):
(WebCore::Layout::FloatingContext::constraints const):
(WebCore::Layout::FloatingContext::absoluteCoordinates const):
(WebCore::Layout::FloatingContext::mapTopLeftToPlacedFloatsRoot const):
(WebCore::Layout::FloatingContext::mapPointFromFormattingContextRootToPlacedFloatsRoot const):
(WebCore::Layout::FloatingContext::isFloatingCandidateStartPositionedInPlacedFloats const):
(WebCore::Layout::FloatingContext::clearInPlacedFloats const):
* Source/WebCore/layout/floats/PlacedFloats.h:
(WebCore::Layout::PlacedFloats::blockFormattingContextRoot const):
(WebCore::Layout::PlacedFloats::formattingContextRoot const): Deleted.
(WebCore::Layout::PlacedFloats::writingMode const): Deleted.
(WebCore::Layout::PlacedFloats::setWritingMode): Deleted.
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::updateRenderTreePositions):
(WebCore::LayoutIntegration::LineLayout::preparePlacedFloats):

Canonical link: https://commits.webkit.org/286720@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications