[webkit-changes] [WebKit/WebKit] 6acc88: Child text-decoration-thickness and text-underline...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6acc886e4f70a0c26c7af2820da0b11de12d6c50
      https://github.com/WebKit/WebKit/commit/6acc886e4f70a0c26c7af2820da0b11de12d6c50
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-11-15 (Fri, 15 Nov 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/reference/text-decoration-thickness-single2-notref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-single2-expected-mismatch.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-single2.html
    M Source/WebCore/rendering/TextDecorationPainter.cpp

  Log Message:
  -----------
  Child text-decoration-thickness and text-underline-offset override parent decorating boxes' values
https://bugs.webkit.org/show_bug.cgi?id=213554
<rdar://problem/64705955>

Reviewed by Antti Koivisto.

It's not only redundant to run "skip boundaries" with no underline intersection, but also
prevents us from painting tall underline on short inline content (due to the linear nature of dilation in translateIntersectionPointsToSkipInkBoundaries)

* Source/WebCore/rendering/TextDecorationPainter.cpp:
(WebCore::TextDecorationPainter::paintBackgroundDecorations):

Canonical link: https://commits.webkit.org/286639@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications