[webkit-changes] [WebKit/WebKit] c4bcfc: AX: VoiceOver typing echo doesn't work in PDF form...

Commit Queue noreply at github.com
Thu Nov 14 17:53:28 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c4bcfc5ab5370240f1a989cf9406df823b49da81
      https://github.com/WebKit/WebKit/commit/c4bcfc5ab5370240f1a989cf9406df823b49da81
  Author: Utku Uckun <u_uckun at apple.com>
  Date:   2024-11-14 (Thu, 14 Nov 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.mm

  Log Message:
  -----------
  AX: VoiceOver typing echo doesn't work in PDF form fields
https://bugs.webkit.org/show_bug.cgi?id=283089
rdar://139835695

Reviewed by Tyler Wilcock.

PDFs are hosted in a different process than Safari. With the current implementation all the PDF accessibility elements lack the Safari PID. Therefore, VoiceOver cannot add accessibility observers to these PDF accessibility elements.
This fix adds the application PID to WKAccessibilityPDFDocumentObject where all the descendant PDF AX nodes can inherit the same PID. This fixes the typing echo missing in PDF text fields when Isolated Tree Mode is disabled. Another fix will be submitted to fix typing echo and other VoiceOver issues in PDFs when ITM is enabled.

* Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.mm:
(-[WKAccessibilityPDFDocumentObject initWithPDFDocument:andElement:]):

Canonical link: https://commits.webkit.org/286623@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list