[webkit-changes] [WebKit/WebKit] c64901: REGRESSION(286456 at main) [WebDriver] WebAutomationS...

[Lauro Moura]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c64901beb5ef6972192fd5077d5a8db0572cb4a4
      https://github.com/WebKit/WebKit/commit/c64901beb5ef6972192fd5077d5a8db0572cb4a4
  Author: Lauro Moura <lmoura at igalia.com>
  Date:   2024-11-12 (Tue, 12 Nov 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp

  Log Message:
  -----------
  REGRESSION(286456 at main) [WebDriver] WebAutomationSessionProxy::evaluateJavaScriptFunction completionHandler should always be called
https://bugs.webkit.org/show_bug.cgi?id=282983

Reviewed by BJ Burg.

Ensure we call the completionHandler for a given callbackID to avoid the
operation from blocking.

The expectsImplicitCallbackArgument parameter is related to the JS
function being evaluated having a "resolver" callback that will be
called with the result of the evaluation, and is already handled by the
JS implementation of evaluateJavaScriptFunction.

* Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::evaluateJavaScriptFunction):

Canonical link: https://commits.webkit.org/286495@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications