[webkit-changes] [WebKit/WebKit] 09a39c: Remove `WKBundlePageGetMainFrame` use in `Injected...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 09a39c7410120fcf29cdb6310eabad53edaba847
      https://github.com/WebKit/WebKit/commit/09a39c7410120fcf29cdb6310eabad53edaba847
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-11-08 (Fri, 08 Nov 2024)

  Changed paths:
    M LayoutTests/platform/mac-site-isolation/TestExpectations
    M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h
    M Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp

  Log Message:
  -----------
  Remove `WKBundlePageGetMainFrame` use in `InjectedBundlePage::shouldInsertNode`
https://bugs.webkit.org/show_bug.cgi?id=282856
rdar://139541150

Reviewed by Wenson Hsieh.

Using `WKBundlePageGetMainFrame` when the main frame is out-of-process leads to a crash. We should use
the frame associated with the `WKBundleNodeHandleRef` instead.

* LayoutTests/platform/mac-site-isolation/TestExpectations:
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(WKBundleNodeHandleCopyOwningDocumentFrame):
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::dumpPath):
(WTR::string):
(WTR::InjectedBundlePage::shouldInsertNode):

Canonical link: https://commits.webkit.org/286372@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications