[webkit-changes] [WebKit/WebKit] f7cebf: ARMv7: don't generate invalid Index Air args

[aoikonomopoulos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f7cebf1b0a52b3de4b43f168bac8d1ceb98f59b6
      https://github.com/WebKit/WebKit/commit/f7cebf1b0a52b3de4b43f168bac8d1ceb98f59b6
  Author: Angelos Oikonomopoulos <angelos at igalia.com>
  Date:   2024-11-07 (Thu, 07 Nov 2024)

  Changed paths:
    M Source/JavaScriptCore/b3/B3LowerToAir32_64.cpp
    M Source/JavaScriptCore/b3/B3MemoryValueInlines.h
    M Source/JavaScriptCore/b3/testb3_failingArmV7Tests.inc

  Log Message:
  -----------
  ARMv7: don't generate invalid Index Air args
https://bugs.webkit.org/show_bug.cgi?id=282685

Reviewed by Justin Michaud.

Not all indexes are valid for floats. Make sure we check that the Air
form is valid and use a fallback if not.

While looking at this, update MemoryValue::isLegalOffsetImpl to pass the
appropriate move type to isValidAddrForm, as, again, floats have
different constraints on ARMv7.

Enable a couple of tests that now pass.

* Source/JavaScriptCore/b3/B3LowerToAir32_64.cpp:
* Source/JavaScriptCore/b3/B3MemoryValueInlines.h:
(JSC::B3::MemoryValue::isLegalOffsetImpl const):
* Source/JavaScriptCore/b3/testb3_failingArmV7Tests.inc:

Canonical link: https://commits.webkit.org/286298@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications