[webkit-changes] [WebKit/WebKit] c85579: export-w3c-test-changes should allow the branch to...

Sam Sneddon noreply at github.com
Wed Nov 6 15:21:50 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c85579a8aa15e58422e888e2aa06e4fb78c91852
      https://github.com/WebKit/WebKit/commit/c85579a8aa15e58422e888e2aa06e4fb78c91852
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2024-11-06 (Wed, 06 Nov 2024)

  Changed paths:
    M Tools/Scripts/webkitpy/w3c/test_exporter.py
    M Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py

  Log Message:
  -----------
  export-w3c-test-changes should allow the branch to be kept on failure
https://bugs.webkit.org/show_bug.cgi?id=270348
rdar://problem/124269575

Reviewed by Sihui Liu.

This adds two arguments:

 * --no-clean, which toggles doing any cleanup, even on success
 * --clean-on-failure, which toggles cleaning up on failure

While we're at it, avoid needlessly running:

    git checkout master
    git reset --hard origin
    git checkout master

at the end of execution. We can just checkout once, and just leave
master as it is.

* Tools/Scripts/webkitpy/w3c/test_exporter.py:
(WebPlatformTestExporter.delete_local_branch):
(WebPlatformTestExporter.do_export):
(parse_args):
* Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py:
(TestExporterTest.test_export):
(TestExporterTest.test_export_with_specific_branch):
(TestExporterTest):
(TestExporterTest.test_export_no_clean):

Canonical link: https://commits.webkit.org/286253@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list