[webkit-changes] [WebKit/WebKit] 4917f5: Timer should hold a CheckedRef to the object befor...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4917f5eb6c8729b1f573a6f8f98665c4ce820849
      https://github.com/WebKit/WebKit/commit/4917f5eb6c8729b1f573a6f8f98665c4ce820849
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-11-04 (Mon, 04 Nov 2024)

  Changed paths:
    M Source/WTF/wtf/RunLoop.h
    M Source/WTF/wtf/StdLibExtras.h
    M Source/WTF/wtf/TypeTraits.h
    M Source/WTF/wtf/UniqueRef.h
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/html/parser/HTMLDocumentParser.cpp
    M Source/WebCore/loader/DocumentLoader.cpp
    M Source/WebCore/loader/FrameLoader.cpp
    M Source/WebCore/loader/NavigationScheduler.cpp
    M Source/WebCore/loader/NavigationScheduler.h
    M Source/WebCore/loader/SubframeLoader.cpp
    M Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp
    M Source/WebCore/page/Frame.cpp
    M Source/WebCore/page/Frame.h
    M Source/WebCore/page/History.cpp
    M Source/WebCore/page/LocalDOMWindow.cpp
    M Source/WebCore/page/Location.cpp
    M Source/WebCore/page/Navigation.cpp
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/RemoteDOMWindow.cpp
    M Source/WebCore/platform/Timer.h
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
    M Source/WebKit/NetworkProcess/NetworkSocketChannel.cpp
    M Source/WebKit/NetworkProcess/NetworkSocketChannel.h
    M Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.h
    M Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.mm
    M Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.cpp
    M Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.h
    M Source/WebKit/NetworkProcess/soup/WebSocketTaskSoup.cpp
    M Source/WebKit/NetworkProcess/soup/WebSocketTaskSoup.h

  Log Message:
  -----------
  Timer should hold a CheckedRef to the object before calling the timeout function on it, when possible
https://bugs.webkit.org/show_bug.cgi?id=282474

Reviewed by Ryosuke Niwa and Darin Adler.

Timer should hold a CheckedRef to the object before calling the timeout
function on it, when possible.

We use a RefPtr if the class if ref-counted, otherwise we fallback to
using a CheckedRef if the class subclasses CanMakeCheckedPtr, otherwise,
we fallback to legacy behavior.

* Source/WTF/wtf/RunLoop.h:
* Source/WTF/wtf/StdLibExtras.h:
(WTF::makeUnique):
(WTF::makeUniqueWithoutFastMallocCheck):
* Source/WTF/wtf/TypeTraits.h:
* Source/WTF/wtf/UniqueRef.h:
(WTF::makeUniqueRef):
* Source/WebCore/platform/Timer.h:
(WebCore::Timer::Timer):

Canonical link: https://commits.webkit.org/286084@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications