[webkit-changes] [WebKit/WebKit] deb1e9: com.apple.WebKit.WebContent at com.apple.WebCore: ...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: deb1e9b679b8b7be5fa5ee404eefdbe61077edb4
      https://github.com/WebKit/WebKit/commit/deb1e9b679b8b7be5fa5ee404eefdbe61077edb4
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2024-11-01 (Fri, 01 Nov 2024)

  Changed paths:
    M Source/WebCore/platform/mac/ScrollbarsControllerMac.h
    M Source/WebCore/platform/mac/ScrollbarsControllerMac.mm
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    A Tools/TestWebKitAPI/Tests/WebCore/cocoa/ScrollbarWidthCrash.mm

  Log Message:
  -----------
  com.apple.WebKit.WebContent at com.apple.WebCore:  WebCore::LocalFrameViewLayoutContext::performLayout
https://bugs.webkit.org/show_bug.cgi?id=282362
rdar://138879934

Reviewed by Simon Fraser.

When updating ScrollbarsControllerMac for a scrollbar width change, previously we were re-using code to
update the NSScrollerImps for the width change, but this function also notifies the scrollable area of
the scrollbar width change, which will eventually call down into layout code, causing an assert. To fix this
factor out the code that updates the NSScrollerImps, as the scrollable area will properly update its width without
the call into scrollbarStyleChanged.

* Source/WebCore/platform/mac/ScrollbarsControllerMac.h:
* Source/WebCore/platform/mac/ScrollbarsControllerMac.mm:
(WebCore::ScrollbarsControllerMac::updateScrollerImps):
(WebCore::ScrollbarsControllerMac::updateScrollerStyle):
(WebCore::ScrollbarsControllerMac::scrollbarWidthChanged):

Canonical link: https://commits.webkit.org/286023@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications