[webkit-changes] [WebKit/WebKit] fca5df: [css-masonry] Fix masonry-intrinsic-sizing-rows-00...

Brandon Stewart noreply at github.com
Fri Nov 1 13:14:10 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fca5dff820c0e221d53c4e448ab3f093dff1c446
      https://github.com/WebKit/WebKit/commit/fca5dff820c0e221d53c4e448ab3f093dff1c446
  Author: Brandon Stewart <brandonstewart at apple.com>
  Date:   2024-11-01 (Fri, 01 Nov 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-002-mix2-expected.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-002-mix2-ref.html

  Log Message:
  -----------
  [css-masonry] Fix masonry-intrinsic-sizing-rows-002-mix2
https://bugs.webkit.org/show_bug.cgi?id=282352
rdar://problem/138945390

Reviewed by Sammy Gill.

There were 3 issues with the test case:

Test 1:
Rows 2 and 4 are auto and 1fr.
These need to both be 2ch, because 1 gets placed in both during track sizing.

Test 2:
Same as test 1.

Test 4:
Item 5 was placed in the wrong row.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-002-mix2-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-002-mix2-ref.html:

Canonical link: https://commits.webkit.org/286019@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list